Add tiny fixes #71
Merged
Add tiny fixes #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfsnow
commented
Dec 17, 2024
| @@ -1,2 +1,3 @@ | |||
| ARROW_S3=ON | |||
| ARROW_WITH_SNAPPY=ON | |||
| AWS_REGION=us-east-1 | |||
There was a problem hiding this comment.
This is present in the res repo but not this one. Not having it causes the SNS topic publish to fail.
dfsnow
commented
Dec 17, 2024
Comment on lines
+91
to
+95
| if (sum(!is.na(n_sales)) >= min_n) { | ||
| return(fn) | ||
| } else { | ||
| return(rep(na_type, length(n_sales))) | ||
| } |
There was a problem hiding this comment.
dfsnow
commented
Dec 17, 2024
There was a problem hiding this comment.
All the changes in this file were just automatically performed by renv.
dfsnow
commented
Dec 17, 2024
There was a problem hiding this comment.
The deps in this lockfile were slightly ahead of the versions in the default renv.lock. This resulted in a renv out of sync error in production because we install these deps using renv::restore(lockfile="renv/profiles/reporting/renv.lock"), meaning they overwrite whatever version is initially installed from the default lockfile.
Syncing the versions fixes this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few tiny fixes to get the residential model up and running. See PR comments for details.